Skip to content

Add Persona picker in Editor#1171

Merged
7w1 merged 1 commit into
SableClient:devfrom
j0lol:feat/persona-picker
Jul 21, 2026
Merged

Add Persona picker in Editor#1171
7w1 merged 1 commit into
SableClient:devfrom
j0lol:feat/persona-picker

Conversation

@j0lol

@j0lol j0lol commented Jul 21, 2026

Copy link
Copy Markdown

Description

Add a PMP/Persona picker in the room input, so a user can switch between personas graphically (without shorthands or /usepmp.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@j0lol

j0lol commented Jul 21, 2026

Copy link
Copy Markdown
Author

Names and such are in a bit of a rough state but it is MVP "working". Going to work on it a bit more before I'm comfortable un-drafting this.

Screencast_20260721_011126.webm

(In the video the first switch is buggy, but the rest work fine.)

Making UI for plural systems is new territory, so I'd like feedback from other systems if possible. I'm asking around for feedback.

@cyrneko

cyrneko commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

fwiw, while I'm here I'll leave some thoughts that j0 already knows of but I didn't share publicly yet:

I believe that good keyboard navigation would be very nice to have, in addition to using prefixes or pk; commands like what Sable already does

I was thinking something like alt+P or alt+ might work? From that point on the search is focused, or entries could be manually tabbed/↓↑ through

@j0lol
j0lol force-pushed the feat/persona-picker branch from 3955005 to fc5cd8b Compare July 21, 2026 19:12
@j0lol

j0lol commented Jul 21, 2026

Copy link
Copy Markdown
Author

Un-drafting. I'm trying to get an MVP through, which can hopefully be made more usable in subsequent PRs. There's other areas of Sable that need better plural UX which would be good to focus on first. Please do review the code, it's my first time contributing to this codebase and there's probably things that could be done better.

image

@j0lol
j0lol marked this pull request as ready for review July 21, 2026 19:17
@j0lol
j0lol requested review from 7w1 and hazre as code owners July 21, 2026 19:17
@j0lol j0lol changed the title Add Persona picker in Room Input Add Persona picker in Editor Jul 21, 2026
Comment thread src/app/features/room/RoomInput.tsx
@j0lol
j0lol force-pushed the feat/persona-picker branch 3 times, most recently from 89e622b to 7cd60ed Compare July 21, 2026 20:05
Comment thread src/app/features/room/persona-picker/PersonaPicker.tsx Outdated
Comment thread src/app/features/room/persona-picker/PersonaPicker.tsx Outdated
@j0lol
j0lol force-pushed the feat/persona-picker branch from 7cd60ed to 8101452 Compare July 21, 2026 20:48
@j0lol
j0lol force-pushed the feat/persona-picker branch from 8101452 to 30e158c Compare July 21, 2026 21:51
@7w1
7w1 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into SableClient:dev with commit 7a327f6 Jul 21, 2026
12 checks passed
@CrimsonFork

Copy link
Copy Markdown

Coming over from https://shrimp.starlightnet.work/notes/aoxhcs2danft1dwb , it seems We're a bit late, but still would like to add that it'd be nice to have a centralized history of used "personas" somewhere, preferably not local to a given client. With Plural Kitty We've been able to go back in the control room history and easily find out when e.g. one of Us had a last or second to last front a year ago, which is something that'd be a lot more difficult to achieve by looking through the regular history of rooms, which may or may not even contain messages from that particular time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants